Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Update ipxe version to May 2024 #593

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

elfosardo
Copy link
Member

This is yet another tentative to make ipxe more close to the current version and include some improvements and bug fixes.

We point the ipxe commit hash to [1] from May 2024, so roughly 6 months of changes are included.
To see the complete list of changes run:
git log --pretty=oneline 119c41..e965f17
from a local clone of the ipxe repository.

In general the changes included between the old hash and the current chosen hash improve compatibility
with recent gcc and build libraries, while fixing
numerous bugs.

On a side note, this is the minimum commit required to build ipxe on CentOS Stream 10.

This is a follow up to 4955fbb

[1] ipxe/ipxe@e965f17

This is yet another tentative to make ipxe more close to the
current version and include some improvements and bug fixes.

We point the ipxe commit hash to [1] from May 2024, so
roughly 6 months of changes are included.
To see the complete list of changes run:
`git log --pretty=oneline 119c41..e965f17`
from a local clone of the ipxe repository.

In general the changes included between the old hash
and the current chosen hash improve compatibility
with recent gcc and build libraries, while fixing
numerous bugs.

On a side note, this is the minimum commit required to build
ipxe on CentOS Stream 10.

This is a follow up to metal3-io@4955fbb

[1] ipxe/ipxe@e965f17

Signed-off-by: Riccardo Pittau <[email protected]>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 28, 2024
@elfosardo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@elfosardo
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

@elfosardo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main

@tuminoid
Copy link
Member

/cc @Rozzii

@metal3-io-bot metal3-io-bot requested a review from Rozzii November 29, 2024 05:30
@elfosardo
Copy link
Member Author

/cc @dtantsur

Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2024
@derekhiggins
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2024
@metal3-io-bot metal3-io-bot merged commit d003ad5 into metal3-io:main Dec 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants